TutorTask531_Create_data_downloader_for_EIA#542
Merged
Conversation
sonniki
requested changes
May 30, 2025
Contributor
sonniki
left a comment
sonniki
left a comment
There was a problem hiding this comment.
The overall logic looks good, just some improvements
causal_automl/TutorTask401_EIA_metadata_downloader_pipeline/eia_utils.py
Outdated
Show resolved
Hide resolved
This was referenced May 30, 2025
sonniki
added
PR_for_authors
Collaborator
Author
|
Error handling |
sonniki
requested changes
Jun 2, 2025
Contributor
sonniki
left a comment
sonniki
left a comment
There was a problem hiding this comment.
A couple of tiny final things and then we'll merge
causal_automl/TutorTask401_EIA_metadata_downloader_pipeline/eia_utils.py
Outdated
Show resolved
Hide resolved
causal_automl/TutorTask401_EIA_metadata_downloader_pipeline/eia_utils.py
Outdated
Show resolved
Hide resolved
causal_automl/TutorTask401_EIA_metadata_downloader_pipeline/eia_utils.py
Outdated
Show resolved
Hide resolved
gpsaggese
reviewed
Jun 2, 2025
Collaborator
gpsaggese
left a comment
gpsaggese
left a comment
There was a problem hiding this comment.
Nothing from me. Good code
Collaborator
Author
|
@sonniki Should I be concerned with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #531.
Downloader class will use
myeiaAPI wrapper for EIA API v2.